Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/845#discussion_r45262050
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -476,14 +539,21 @@
                                                (:sync-retry supervisor))
               new-assignment (->> all-assignment
                                   (filter-key #(.confirmAssigned isupervisor 
%)))
    -          assigned-storm-ids (assigned-storm-ids-from-port-assignments 
new-assignment)]
    +          rm-blob-refs? true
    +          assigned-storm-ids (assigned-storm-ids-from-port-assignments 
new-assignment)
    +          localizer (:localizer supervisor)
    +          checked-downloaded-storm-ids (set (verify-downloaded-files conf 
localizer assigned-storm-ids all-downloaded-storm-ids))
    +          downloaded-storm-ids (set/difference all-downloaded-storm-ids 
checked-downloaded-storm-ids)]
    +
           (log-debug "Synchronizing supervisor")
           (log-debug "Storm code map: " storm-code-map)
    -      (log-debug "Downloaded storm ids: " downloaded-storm-ids)
           (log-debug "All assignment: " all-assignment)
           (log-debug "New assignment: " new-assignment)
    +      (log-debug "Assigned Storm Ids" assigned-storm-ids)
    +      (log-debug "All Downloaded Ids" all-downloaded-storm-ids)
    +      (log-debug "Checked Downloaded Ids" checked-downloaded-storm-ids)
    +      (log-debug "Downloaded Ids" downloaded-storm-ids)
    --- End diff --
    
    minor thing: Could we add spaces to clean up the log messages here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to