[ 
https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137437#comment-15137437
 ] 

ASF GitHub Bot commented on STORM-1226:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52206422
  
    --- Diff: storm-core/pom.xml ---
    @@ -42,6 +42,10 @@
                 This is here as a work around to place it at the beginning of 
the classpath
                 even though maven does not officially support ordering of the 
classpath.-->
             <dependency>
    +            <groupId>uk.org.lidalia</groupId>
    +            <artifactId>sysout-over-slf4j</artifactId>
    +        </dependency>
    --- End diff --
    
    The new dependency seems OK, and it is unlikely that we will encounter some 
topology already using this, but could we please shade it anyways?


> Port backtype.storm.util to java
> --------------------------------
>
>                 Key: STORM-1226
>                 URL: https://issues.apache.org/jira/browse/STORM-1226
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Reza Farivar
>              Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java.  In as many instances as 
> possible the same interface should be maintained, and calls to clojure 
> functions in the rest of the code should be replaces with calls to the 
> corresponding java code.
> Some similar functions can be found at  
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback 
> interfaces instead.  Please try to avoid using clojure internal java classes 
> unless necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to