[ 
https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137504#comment-15137504
 ] 

ASF GitHub Bot commented on STORM-1226:
---------------------------------------

Github user abhishekagarwal87 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1074#discussion_r52211622
  
    --- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
    @@ -71,6 +72,8 @@
                                                               
(:worker->resources assignment)))))
         thrift-assignment))
     
    +;TODO: when translating this function, you should replace the map-val with 
a proper for loop HERE
    +;TODO: when translating this function, you should replace the map-key with 
a proper for loop HERE
    --- End diff --
    
    duplicate comment.


> Port backtype.storm.util to java
> --------------------------------
>
>                 Key: STORM-1226
>                 URL: https://issues.apache.org/jira/browse/STORM-1226
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Reza Farivar
>              Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java.  In as many instances as 
> possible the same interface should be maintained, and calls to clojure 
> functions in the rest of the code should be replaces with calls to the 
> corresponding java code.
> Some similar functions can be found at  
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback 
> interfaces instead.  Please try to avoid using clojure internal java classes 
> unless necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to