[
https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137461#comment-15137461
]
ASF GitHub Bot commented on STORM-1226:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52208015
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -262,13 +266,16 @@
:task->component (:task->component worker)
:stream->component->grouper (outbound-components worker-context
component-id storm-conf)
:report-error (throttled-report-error-fn <>)
- :report-error-and-die (fn [error]
- ((:report-error <>) error)
- (if (or
- (exception-cause? InterruptedException
error)
- (exception-cause?
java.io.InterruptedIOException error))
- (log-message "Got interrupted excpetion
shutting thread down...")
- ((:suicide-fn <>))))
+ :report-error-and-die (reify
+ Thread$UncaughtExceptionHandler
+ (uncaughtException [this _ error]
+ (fn [error]
--- End diff --
uncaughtException returns a void, so this function we are creating is
thrown away, and never called.
> Port backtype.storm.util to java
> --------------------------------
>
> Key: STORM-1226
> URL: https://issues.apache.org/jira/browse/STORM-1226
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Reza Farivar
> Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java. In as many instances as
> possible the same interface should be maintained, and calls to clojure
> functions in the rest of the code should be replaces with calls to the
> corresponding java code.
> Some similar functions can be found at
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback
> interfaces instead. Please try to avoid using clojure internal java classes
> unless necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
