Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r69672262
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/base/BaseWindowedBolt.java ---
@@ -66,10 +66,14 @@ public String toString() {
* Holds a Time duration for time based windows and sliding intervals.
*/
public static class Duration {
- public final int value;
+ public final long value;
public Duration(int value, TimeUnit timeUnit) {
- this.value = (int) timeUnit.toMillis(value);
+ this.value = timeUnit.toMillis(value);
+ }
+
+ public Duration(long value) {
--- End diff --
Please add TimeUnit as a second arg instead of automatically assuming the
time unit. Also have an overloaded `public static Duration of(long
milliseconds)`. For other static factories long does not make much sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
