Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1527#discussion_r69674507
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/trident/windowing/config/WindowConfig.java 
---
    @@ -31,13 +31,13 @@
          * Returns the length of the window.
          * @return
          */
    -    public int getWindowLength();
    +    public long getWindowLength();
    --- End diff --
    
    If we want to change counts also to `Long` then `SlidingCountWindow` and 
`TumblingCountWindow` should be changed respectively. But there is no real need 
to have `Long` for count based windowing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to