Github user darionyaphet commented on a diff in the pull request:
https://github.com/apache/storm/pull/1527#discussion_r70831175
--- Diff:
storm-core/src/jvm/org/apache/storm/topology/WindowedBoltExecutor.java ---
@@ -76,7 +76,7 @@ public WindowedBoltExecutor(IWindowedBolt bolt) {
this.bolt = bolt;
}
- private int getTopologyTimeoutMillis(Map stormConf) {
+ private long getTopologyTimeoutMillis(Map stormConf) {
--- End diff --
finally , the return value is `timeout * 1000` , it have convert to
millisecond . Long is a better choose .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
