Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1527#discussion_r69672789
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/windowing/CountEvictionPolicy.java ---
    @@ -26,10 +26,10 @@
      * @param <T> the type of event tracked by this policy.
      */
     public class CountEvictionPolicy<T> implements EvictionPolicy<T> {
    -    private final int threshold;
    +    private final long threshold;
    --- End diff --
    
    For counts int should be sufficient. 
    
    If you are changing it to long, the `currentCount` below should be changed 
to AtomicLong. You should also change the definition of `Count` class and add 
overloaded methods to take a long value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to