Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1679#discussion_r79465128
  
    --- Diff: 
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/SingleTopicKafkaSpoutTest.java
 ---
    @@ -0,0 +1,248 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + *   or more contributor license agreements.  See the NOTICE file
    + *   distributed with this work for additional information
    + *   regarding copyright ownership.  The ASF licenses this file
    + *   to you under the Apache License, Version 2.0 (the
    + *   "License"); you may not use this file except in compliance
    + *   with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *   Unless required by applicable law or agreed to in writing, software
    + *   distributed under the License is distributed on an "AS IS" BASIS,
    + *   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    + *   See the License for the specific language governing permissions and
    + *   limitations under the License.
    + */
    +package org.apache.storm.kafka.spout;
    +
    +import info.batey.kafka.unit.KafkaUnitRule;
    +import kafka.producer.KeyedMessage;
    +import org.apache.kafka.clients.consumer.OffsetAndMetadata;
    +import 
org.apache.storm.kafka.spout.builders.SingleTopicKafkaSpoutConfiguration;
    +import org.apache.storm.spout.SpoutOutputCollector;
    +import org.apache.storm.task.TopologyContext;
    +import org.apache.storm.tuple.Values;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.mockito.ArgumentCaptor;
    +
    +import static org.junit.Assert.*;
    +
    +import java.util.Map;
    +import java.util.stream.IntStream;
    +import static 
org.apache.storm.kafka.spout.builders.SingleTopicKafkaSpoutConfiguration.*;
    +import static org.mockito.Mockito.*;
    +
    +public class SingleTopicKafkaSpoutTest {
    +
    +    @Rule
    +    public KafkaUnitRule kafkaUnitRule = new KafkaUnitRule();
    +
    +
    +    void populateTopicData(String topicName, int msgCount) {
    +        kafkaUnitRule.getKafkaUnit().createTopic(topicName);
    +
    +        IntStream.range(0, msgCount).forEach(value -> {
    +            KeyedMessage<String, String> keyedMessage = new KeyedMessage<>(
    +                    topicName, ((Integer)value).toString(),
    +                    ((Integer)value).toString());
    +
    +            kafkaUnitRule.getKafkaUnit().sendMessages(keyedMessage);
    +        });
    +    }
    +
    +    private void assertOffset(int offset, KafkaSpout.OffsetEntry entry) {
    --- End diff --
    
    Consider renaming to something more descriptive, like assertOffsetCommitted 
or something like that. It isn't really obvious from the name what this does


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to