Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1679#discussion_r79463551
  
    --- Diff: 
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
 ---
    @@ -266,26 +266,32 @@ private void doSeekRetriableTopicPartitions() {
                 if (offsetAndMeta != null) {
                     kafkaConsumer.seek(rtp, offsetAndMeta.offset() + 1);  // 
seek to the next offset that is ready to commit in next commit cycle
                 } else {
    -                kafkaConsumer.seekToEnd(toArrayList(rtp));    // Seek to 
last committed offset
    +                kafkaConsumer.seek(rtp, acked.get(rtp).committedOffset + 
1);    // Seek to last committed offset
                 }
             }
         }
     
         // ======== emit  =========
         private void emit() {
    -        emitTupleIfNotEmitted(waitingToEmit.next());
    +        //Keep trying to send a tuple when requested
    +        while(!emitTupleIfNotEmitted(waitingToEmit.next()) && 
waitingToEmit.hasNext())
    --- End diff --
    
    While I don't think it hurts, I don't see why this is necessary. Storm 
should call nextTuple repeatedly until something is emitted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to