Github user erikdw commented on a diff in the pull request:
https://github.com/apache/storm/pull/2109#discussion_r116677826
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -139,8 +139,8 @@ public void
onPartitionsRevoked(Collection<TopicPartition> partitions) {
@Override
public void onPartitionsAssigned(Collection<TopicPartition>
partitions) {
- LOG.info("Partitions reassignment. [consumer-group={},
consumer={}, topic-partitions={}]",
- kafkaSpoutConfig.getConsumerGroupId(), kafkaConsumer,
partitions);
+ LOG.info("Partitions reassignment. [task-ID={},
consumer-group={}, consumer={}, topic-partitions={}]",
--- End diff --
Thanks Srishty. Regarding `taskId()` being a function name as the
justification for `taskID` being the variable name: in at least one case the
name of the function is bad and should be changed. i.e., KafkaUtils.java's
`taskId()` should be `taskPrefix()` or something else. It's *not* the "Task
ID".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
