Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2109
  
    @erikdw Isn't naming variables e.g. `FOO_BAR` usually reserved for 
constants that are both static and final? I wouldn't usually expect non-static 
finals to be all caps. The `ignoreStatic` default of `true` seems to catch 
static final constants, so I don't think we need to change `ignoreFinal`?
    
    
https://github.com/apache/storm/blob/master/external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java#L61
 isn't causing a violation for example.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to