Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r152706078
  
    --- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
    @@ -792,15 +795,18 @@
           (bind _ (log-message "ass1, t76, pre beat: " (pr-str ass1)))
           (bind _ (log-message "ass2, t76, pre beat: " (pr-str ass2)))
           (is (= ass1 (executor-assignment cluster storm-id executor-id1)))
    -      (is (not= ass2 (executor-assignment cluster storm-id executor-id2)))
    +      ;TODO: fix local test of worker reports
    --- End diff --
    
    Should this be fixed before merging patch in? If then let's document it to 
PR's body so that we don't miss this. If not, let's file a new JIRA issue for 
this.


---

Reply via email to