Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2433#discussion_r152702341
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java 
---
    @@ -50,25 +51,14 @@
     import org.apache.storm.executor.ExecutorShutdown;
     import org.apache.storm.executor.IRunningExecutor;
     import org.apache.storm.executor.LocalExecutor;
    -import org.apache.storm.generated.Credentials;
    -import org.apache.storm.generated.ExecutorInfo;
    -import org.apache.storm.generated.ExecutorStats;
    -import org.apache.storm.generated.LSWorkerHeartbeat;
    -import org.apache.storm.generated.LogConfig;
    +import org.apache.storm.generated.*;
    --- End diff --
    
    Using wildcard(*) in import is discouraged in Storm project. If it is 
automated by IDE, please increase the count (I'm using 999) to convert imports 
to *.


---

Reply via email to