Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r160241080
  
    --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
    @@ -1023,6 +1023,43 @@
         public static String STORM_SUPERVISOR_MEDIUM_MEMORY_GRACE_PERIOD_MS =
             "storm.supervisor.medium.memory.grace.period.ms";
     
    +    /**
    +     * Class implementing MetricStore.
    +     */
    +    @NotNull
    +    @isString
    +    public static final String STORM_METRIC_STORE_CLASS = 
"storm.metricstore.class";
    +
    +    /**
    +     * RocksDB file location.
    --- End diff --
    
    Could we expand the javadocs to explain that this is only for the 
`org.apache.storm.metricstore.rocksdb.RocksDbStore`, and that would be good for 
all of the newly added javadocs that are specific to the RocksDBMetaStore.
      


---

Reply via email to