Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2504#discussion_r160243540 --- Diff: storm-server/src/main/java/org/apache/storm/metricstore/MetricStore.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.storm.metricstore; + +import com.codahale.metrics.Meter; + +import java.util.Map; + +public interface MetricStore { --- End diff -- Can we make this extend AutoCloseable?
---