[GitHub] storm pull request #2504: STORM-2156: store metrics into RocksDB

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r160242577
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
    @@ -4166,4 +4184,23 @@ public void shutdown() {
         public boolean isWaiting() {
             return timer.isTimerWaiting();
         }
    +
    +    @Override
    +    public void processWorkerMetrics(WorkerMetrics metrics) throws 
org.apache.thrift.TException {
    +        if (this.metricsStore == null) {
    --- End diff --
    
    Can we add in some authorization calls before we do anything with executing 
the command?
    
    ```
    checkAuthorization(null, null, "processWorkerMetrics");
    ```
    
    Then we would need to update 
    
    
https://github.com/apache/storm/blob/7ecb3d73e8e909c01d39e03a7a7ed45a2fb81859/storm-client/src/jvm/org/apache/storm/security/auth/authorizer/SimpleACLAuthorizer.java#L52
    
    to have processWorkerMetrics in the list.



---