[GitHub] storm pull request #2504: STORM-2156: store metrics into RocksDB

[revans2]

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2504#discussion_r160240938
  
    --- Diff: storm-server/src/main/java/org/apache/storm/DaemonConfig.java ---
    @@ -1023,6 +1023,43 @@
         public static String STORM_SUPERVISOR_MEDIUM_MEMORY_GRACE_PERIOD_MS =
             "storm.supervisor.medium.memory.grace.period.ms";
     
    +    /**
    +     * Class implementing MetricStore.
    +     */
    +    @NotNull
    +    @isString
    --- End diff --
    
    We have an `@isImplementationOfClass` annotation that I think would be more 
appropriate for this config.


---