Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830061
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -133,8 +133,8 @@ public void open(Map<String, Object> conf,
TopologyContext context, SpoutOutputC
tupleListener = kafkaSpoutConfig.getTupleListener();
- if (isAtLeastOnceProcessing()) {
- // Only used if the spout should commit an offset to Kafka
only after the corresponding tuple has been acked.
+ if (kafkaSpoutConfig.getProcessingGuarantee() !=
KafkaSpoutConfig.ProcessingGuarantee.AT_MOST_ONCE) {
+ // In at-most-once mode the offsets are committed after every
poll, so the timer is not used
--- End diff --
In at-most-once mode the offsets are committed after every poll and not
periodically as controlled by the timer.
---
