Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830085
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -307,8 +307,12 @@ public void nextTuple() {
kafkaSpoutConfig.getSubscription().refreshAssignment();
}
- if (shouldCommit()) {
- commitOffsetsForAckedTuples(kafkaConsumer.assignment());
+ if (commitTimer != null && commitTimer.isExpiredResetOnTrue())
{ //commit timer is null for AT_MOST_ONCE mode
--- End diff --
I would say this comment is redundant here. We already say that on the
field, so I suggest that we just remove it.
---
