Github user hmcl commented on a diff in the pull request:
https://github.com/apache/storm/pull/2537#discussion_r165830275
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutConfig.java
---
@@ -453,37 +451,33 @@ public Builder(String bootstrapServers, Subscription
subscription) {
return builder;
}
- private static void setAutoCommitMode(Builder<?, ?> builder) {
+ private static void setPropsToFitProcessingGuarantee(Builder<?, ?>
builder) {
if
(builder.kafkaProps.containsKey(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG)) {
- throw new IllegalArgumentException("Do not set " +
ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG + " manually."
- + " Instead use
KafkaSpoutConfig.Builder.setProcessingGuarantee");
+ throw new IllegalArgumentException("Do not set " +
ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG
--- End diff --
message should be:
Kafka enable.auto.commit is not supported. Please set the desired
ProcessingGuarantee using {@link setProcessingGuarantee}
---
