Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2537#discussion_r165830283
  
    --- Diff: 
external/storm-kafka-client/src/test/java/org/apache/storm/kafka/spout/KafkaSpoutConfigTest.java
 ---
    @@ -85,4 +90,12 @@ public void testMetricsTimeBucketSizeInSecs() {
     
             assertEquals(100, conf.getMetricsTimeBucketSizeInSecs());
         }
    +    
    +    @Test
    +    public void testEnableAutoCommitIsBanned() {
    +        expectedException.expect(IllegalArgumentException.class);
    --- End diff --
    
    IllegalStateException.class


---

Reply via email to