GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2759
STORM-2947: Remove some deprecated methods from Storm 2.0.0.
This handles some of the deprecated things mentioned in STORM-2947.
There'll probably be followups to this PR to remove more functionality, e.g.
the transactional topology API. I've only looked at storm-server and
storm-client, not any of the other listed modules.
Part of https://issues.apache.org/jira/browse/STORM-2947
Removed functionality:
* nimbus_uptime_secs was deprecated here
https://github.com/apache/storm/commit/5c818b093350f572a38a5c59f9e083625b298ddd
* beginFileDownload was deprecated here
https://github.com/apache/storm/commit/547ad08d34ea5c0dbd9cc339c1a4a9d4803ed763
* The Tuple method was deprecated here
https://github.com/apache/storm/commit/68d81ab092e76e790da4c69fc9215fd1f2633821
* GzipBridgeDeserializationDelegate and DefaultDeserializationDelegate were
deprecated here
https://github.com/apache/storm/commit/47bcf3ebe7067e86846057cbca2466d7349b0d98
The default delegate is ThriftSerializationDelegate. I'd be okay with
changing the Utils.getSerializationDelegate code to just error if it can't
instantiate the delegate, that way we don't have the default delegate specified
in two places (defaults.yaml and now Utils)
* The ICredentialsRenewer method was deprecated in
https://github.com/apache/storm/commit/d182584a660707cac36fcf7458f3199819aa303e
* StormCommon.getStormId was deprecated in
https://github.com/apache/storm/commit/725003cc5f488191dda011dda738e41d57eca474.
As far as I can tell, the Java version of this method has not been present in
a release, in 1.x it is clojure code.
* nimbus.hosts was deprecated when 1.0.0 was released, netty max retries
was deprecated in
https://github.com/apache/storm/commit/5a29b30212a5f0e15c6e791758f86eb2bb8a6aa4
Couldn't remove:
* INimbusCredentialsPlugin contains a deprecated method, that cannot be
removed because it is used by Nimbus and some implementations of
INimbusCredentialsPlugin.
* TopologyContext contains some deprecated metrics v1 methods. The methods
are still in use elsewhere in the code, and there's no note in the Javadoc
about how to migrate.
* The transactional topology API, it's a lot of code and I'd rather remove
it in a separate PR than mix it in here.
* TimeCacheMap is used in Nimbus, need to replace it with RotatingMap
before it can be removed.
* A number of other methods that aren't deprecated in 1.x.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-2947
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2759
----
commit 9110436b34b2ba7dc05fd0d76805b71290a4de8c
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-07-10T13:56:34Z
Delete deprecated method and field from thrift, remove deprecated Tuple
method
commit 0c558535f14aa9319e44a81ff65ebf24157efc67
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-07-10T14:30:47Z
Delete deprecated serialization delegates, delete deprecated
FixedTupleSpout method
commit 2dfbcd3048f70dbcbe26aaacad871a374596ad81
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-07-10T14:57:29Z
Remove deprecated methods in ICredentialsRenewer and StormCommon
commit b284abcabfd954674d220baf00add0b9c32e2e51
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-07-10T15:37:09Z
Delete nimbus.hosts and netty max retries config properties
commit eb992cbf4995d5fe71e84a706ec618fdb9390200
Author: Stig Rohde Døssing <srdo@...>
Date: 2018-07-10T16:40:48Z
Fix bugs introduced in earlier commits
----
---
