Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201455774
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -781,7 +781,7 @@ private static SerializationDelegate
getSerializationDelegate(Map<String, Object
delegate = (SerializationDelegate) delegateClass.newInstance();
} catch (ClassNotFoundException | InstantiationException |
IllegalAccessException e) {
LOG.error("Failed to construct serialization delegate, falling
back to default", e);
--- End diff --
I would be okay with just turning this into a throw. The default
serialization delegate is the GzipThriftSerializationDelegate which we should
always be able to instantiate, and I don't see why we wouldn't want to error
out if the user tries to use a different delegate and it doesn't work.
---
