Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2759#discussion_r201931277
--- Diff:
storm-client/src/jvm/org/apache/storm/generated/ClusterSummary.java ---
@@ -29,24 +29,21 @@
private static final org.apache.storm.thrift.protocol.TStruct
STRUCT_DESC = new org.apache.storm.thrift.protocol.TStruct("ClusterSummary");
private static final org.apache.storm.thrift.protocol.TField
SUPERVISORS_FIELD_DESC = new
org.apache.storm.thrift.protocol.TField("supervisors",
org.apache.storm.thrift.protocol.TType.LIST, (short)1);
- private static final org.apache.storm.thrift.protocol.TField
NIMBUS_UPTIME_SECS_FIELD_DESC = new
org.apache.storm.thrift.protocol.TField("nimbus_uptime_secs",
org.apache.storm.thrift.protocol.TType.I32, (short)2);
- private static final org.apache.storm.thrift.protocol.TField
TOPOLOGIES_FIELD_DESC = new
org.apache.storm.thrift.protocol.TField("topologies",
org.apache.storm.thrift.protocol.TType.LIST, (short)3);
- private static final org.apache.storm.thrift.protocol.TField
NIMBUSES_FIELD_DESC = new org.apache.storm.thrift.protocol.TField("nimbuses",
org.apache.storm.thrift.protocol.TType.LIST, (short)4);
+ private static final org.apache.storm.thrift.protocol.TField
TOPOLOGIES_FIELD_DESC = new
org.apache.storm.thrift.protocol.TField("topologies",
org.apache.storm.thrift.protocol.TType.LIST, (short)2);
+ private static final org.apache.storm.thrift.protocol.TField
NIMBUSES_FIELD_DESC = new org.apache.storm.thrift.protocol.TField("nimbuses",
org.apache.storm.thrift.protocol.TType.LIST, (short)3);
private static final org.apache.storm.thrift.scheme.SchemeFactory
STANDARD_SCHEME_FACTORY = new ClusterSummaryStandardSchemeFactory();
private static final org.apache.storm.thrift.scheme.SchemeFactory
TUPLE_SCHEME_FACTORY = new ClusterSummaryTupleSchemeFactory();
private java.util.List<SupervisorSummary> supervisors; // required
- private int nimbus_uptime_secs; // optional
private java.util.List<TopologySummary> topologies; // required
private java.util.List<NimbusSummary> nimbuses; // required
/** The set of fields this struct contains, along with convenience
methods for finding and manipulating them. */
public enum _Fields implements org.apache.storm.thrift.TFieldIdEnum {
SUPERVISORS((short)1, "supervisors"),
- NIMBUS_UPTIME_SECS((short)2, "nimbus_uptime_secs"),
--- End diff --
I'd be cautious if we modify thrift file, since it may break rolling
upgrade. We may want to do manual test, especially rolling upgrade. Might be
better to move the modification of thrift out of PR so that we can review with
more eyes.
---
