[GitHub] storm pull request #2759: STORM-2947: Remove some deprecated methods from St...

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2759#discussion_r202000182
  
    --- Diff: storm-client/src/jvm/org/apache/storm/daemon/StormCommon.java ---
    @@ -85,11 +84,6 @@ public static StormCommon setInstance(StormCommon 
common) {
             return oldInstance;
         }
     
    -    @Deprecated
    --- End diff --
    
    What's worse, this turns an Optional API (getTopoId) into a regular 
non-Optional API.


---