[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209152841
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
 ---
    @@ -253,12 +276,11 @@ private long lastModifiedTimeWorkerLogdir(File 
logDir) {
                             return curr > maximum ? curr : maximum;
                         }, BinaryOperator.maxBy(Long::compareTo));
             } catch (Exception ex) {
    +            //This is not IOException
    --- End diff --
    
    I can't think of one.


---