[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209153420
  
    --- Diff: 
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
 ---
    @@ -18,12 +18,20 @@
     
     package org.apache.storm.daemon.logviewer.utils;
     
    +import com.codahale.metrics.ExponentiallyDecayingReservoir;
    +import com.codahale.metrics.Histogram;
    +
     import java.io.File;
     import java.io.IOException;
     
     import javax.ws.rs.core.Response;
     
    +import org.apache.storm.metric.StormMetricsRegistry;
    +
    +
     public class LogFileDownloader {
    +    private static final Histogram fileDownloadSizeDist = 
StormMetricsRegistry.registerHistogram(
    --- End diff --
    
    Yes, in the metric name. I mean in the variable name. 
    
    I can't immediately see what the unit is in this line
    ```
    fileDownloadSizeDist.update(Math.round(file.length() * 1e-6));
    ```


---