[GitHub] storm pull request #2754: STORM-3133: Extend metrics on Nimbus and LogViewer

[srdo]

Github user srdo commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2754#discussion_r209153726
  
    --- Diff: 
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
 ---
    @@ -627,6 +627,7 @@ public void testFindNMatches() {
     
         public static class TestDeepSearchLogs {
     
    +        public static final int DUMMY_METRICS = 0;
    --- End diff --
    
    But DUMMY_METRICS doesn't say anything about what it is.


---