Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153602
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch(@PathParam("topoId") String
topologyId,
String callback =
request.getParameter(StormApiResource.callbackParameterName);
String origin = request.getHeader("Origin");
- return logSearchHandler.deepSearchLogsForTopology(topologyId,
user, searchString, numMatchesStr, portStr,
- startFileOffset, startByteOffset,
BooleanUtils.toBooleanObject(searchArchived), callback, origin);
+ Boolean alsoSearchArchived =
BooleanUtils.toBooleanObject(searchArchived);
--- End diff --
I mean the metric update here. If you want to track how many times
deepSearchLogsForTopology is called with certain parameters, the metric update
should happen in that function. Otherwise, if I add another call to deepSearch
elsewhere, I'd have to remember to copy this code too.
---
