Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2925#discussion_r240358080
--- Diff: storm-client/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -288,13 +288,15 @@ public void createBlob(String key, InputStream in,
SettableBlobMeta meta, Subjec
while ((len = in.read(buffer)) > 0) {
out.write(buffer, 0, len);
}
- out.close();
- } catch (AuthorizationException | IOException | RuntimeException
e) {
--- End diff --
The documentation for this method indicates that we throw the above
exceptions, however they were being caught instead of thrown. This change will
result in the exceptions being thrown while still helping to guarantee the
`out` stream is closed as the `in` stream was already being ensured to be
closed.
---
