[GitHub] storm pull request #2925: STORM-3302: Ensures we close streams to HDFS

[d2r]

Github user d2r commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2925#discussion_r240366774
  
    --- Diff: 
storm-server/src/main/java/org/apache/storm/blobstore/BlobStoreUtils.java ---
    @@ -204,6 +204,14 @@ public static boolean downloadUpdatedBlob(Map<String, 
Object> conf, BlobStore bl
                 } catch (Exception exp) {
                     // Logging an exception while client is connecting
                     LOG.error("Exception", exp);
    +            } finally {
    +                if (null != out) {
    --- End diff --
    
    Same as above—we probably want to remove the previous call to `close`.  
I'll also fix the style of the conditional to match elsewhere in the file: `out 
!= null`.


---