Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2925#discussion_r240656033
--- Diff: storm-client/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -288,13 +288,15 @@ public void createBlob(String key, InputStream in,
SettableBlobMeta meta, Subjec
while ((len = in.read(buffer)) > 0) {
out.write(buffer, 0, len);
}
- out.close();
- } catch (AuthorizationException | IOException | RuntimeException
e) {
--- End diff --
Formerly they were caught. Removing these lines will result in them being
thrown as both the method documentation and declarations intend.
We may not want this change however, and instead we could update the
declaration and the documentation such that the behavior remains unchanged. I
am willing to do either one, as this PR is focused on eliminating the
possibility of leaking some sockets.
---
