Github user agresch commented on a diff in the pull request:
https://github.com/apache/storm/pull/2925#discussion_r240368505
--- Diff: storm-client/src/jvm/org/apache/storm/blobstore/BlobStore.java ---
@@ -288,13 +288,15 @@ public void createBlob(String key, InputStream in,
SettableBlobMeta meta, Subjec
while ((len = in.read(buffer)) > 0) {
out.write(buffer, 0, len);
}
- out.close();
- } catch (AuthorizationException | IOException | RuntimeException
e) {
- if (out != null) {
- out.cancel();
- }
} finally {
- in.close();
+ try {
+ if (out != null) {
--- End diff --
Previously closed was called in the normal case. Now we're always calling
cancel(). These seem to have slightly different functionality.
---
