bipinprasad commented on a change in pull request #3346:
URL: https://github.com/apache/storm/pull/3346#discussion_r524201586
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3240,14 +3206,15 @@ public void submitTopologyWithOpts(String topoName,
String uploadedJarLocation,
// we might need to set the number of acker executors and
eventlogger executors to be the estimated number of workers.
if (ServerUtils.isRas(conf)) {
int estimatedNumWorker =
ServerUtils.getEstimatedWorkerCountForRasTopo(totalConf, topology);
- int numAckerExecs =
ObjectReader.getInt(totalConf.get(Config.TOPOLOGY_ACKER_EXECUTORS),
estimatedNumWorker);
- int numEventLoggerExecs =
ObjectReader.getInt(totalConf.get(Config.TOPOLOGY_EVENTLOGGER_EXECUTORS),
estimatedNumWorker);
- totalConfToSave.put(Config.TOPOLOGY_ACKER_EXECUTORS,
numAckerExecs);
+ setUpAckerExecutorConfigs(topoName, totalConfToSave,
totalConf, estimatedNumWorker);
+
ServerUtils.validateTopologyAckerBundleResource(totalConfToSave, topology,
topoName);
+
+ int numEventLoggerExecs =
ObjectReader.getInt(totalConf.get(Config.TOPOLOGY_EVENTLOGGER_EXECUTORS),
estimatedNumWorker);
totalConfToSave.put(Config.TOPOLOGY_EVENTLOGGER_EXECUTORS,
numEventLoggerExecs);
+ LOG.info("Config {} set to: {} for topology: {}",
Review comment:
Should this be LOG.debug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
