[GitHub] [storm] Ethanlm commented on a change in pull request #3346: [STORM-3650] attempt to evenly distribute ackers to workers with optional acker-per-worker config

[GitBox]

Ethanlm commented on a change in pull request #3346:
URL: https://github.com/apache/storm/pull/3346#discussion_r524365648



##########
File path: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestBackwardCompatibility.java
##########
@@ -362,12 +363,22 @@ public void 
testDefaultResourceAwareStrategySharedMemory(TestDefaultResourceAwar
     }
 
     @Test
-    public void testDefaultResourceAwareStrategy() {
-        testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategy();
+    public void testDefaultResourceAwareStrategy()
+        throws InvalidTopologyException {
+        
testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategyWithoutSettingAckerExecutors(0);
     }
 
     @Test
-    public void testDefaultResourceAwareStrategyInFavorOfShuffle() {
+    public void 
testDefaultResourceAwareStrategyInFavorOfShuffleWithNewProximityConfig()

Review comment:
       Name should be reverted back

##########
File path: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestBackwardCompatibility.java
##########
@@ -362,12 +363,22 @@ public void 
testDefaultResourceAwareStrategySharedMemory(TestDefaultResourceAwar
     }
 
     @Test
-    public void testDefaultResourceAwareStrategy() {
-        testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategy();
+    public void testDefaultResourceAwareStrategy()
+        throws InvalidTopologyException {
+        
testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategyWithoutSettingAckerExecutors(0);
     }
 
     @Test
-    public void testDefaultResourceAwareStrategyInFavorOfShuffle() {
+    public void 
testDefaultResourceAwareStrategyInFavorOfShuffleWithNewProximityConfig()
+        throws InvalidTopologyException {
+        boolean useDeprecatedConfigForProximity = false;

Review comment:
       Should we remove this

##########
File path: 
storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/scheduling/TestBackwardCompatibility.java
##########
@@ -362,12 +363,22 @@ public void 
testDefaultResourceAwareStrategySharedMemory(TestDefaultResourceAwar
     }
 
     @Test
-    public void testDefaultResourceAwareStrategy() {
-        testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategy();
+    public void testDefaultResourceAwareStrategy()
+        throws InvalidTopologyException {
+        
testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategyWithoutSettingAckerExecutors(0);
     }
 
     @Test
-    public void testDefaultResourceAwareStrategyInFavorOfShuffle() {
+    public void 
testDefaultResourceAwareStrategyInFavorOfShuffleWithNewProximityConfig()
+        throws InvalidTopologyException {
+        boolean useDeprecatedConfigForProximity = false;
+        
testDefaultResourceAwareStrategy.testDefaultResourceAwareStrategyInFavorOfShuffle();
+    }
+
+    @Test
+    public void 
testDefaultResourceAwareStrategyInFavorOfShuffleWithDeprecatedProximityConfig()
+        throws InvalidTopologyException {
+        boolean useDeprecatedConfigForProximity = true;

Review comment:
       and this ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org