bipinprasad commented on a change in pull request #3346:
URL: https://github.com/apache/storm/pull/3346#discussion_r524216682
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/IStrategy.java
##########
@@ -22,9 +23,10 @@
* Scheduler should call {@link #prepare(Map)} followed by {@link
#schedule(Cluster, TopologyDetails)}.
* <p>
* A fully functioning implementation is in the abstract class {@link
BaseResourceAwareStrategy}.
- * Subclasses classes should extend {@link
BaseResourceAwareStrategy#BaseResourceAwareStrategy()}
- * in their constructors as in {@link GenericResourceAwareStrategy},
{@link DefaultResourceAwareStrategy})
- * and {@link ConstraintSolverStrategy}.
+ * Subclasses classes should extend
+ * {@link BaseResourceAwareStrategy#BaseResourceAwareStrategy(boolean,
BaseResourceAwareStrategy.NodeSortType)}
+ * in their constructors (as in {@link GenericResourceAwareStrategy},
{@link DefaultResourceAwareStrategy}
+ * and {@link ConstraintSolverStrategy}).
Review comment:
The javadoc comment should be reverted - signature of extended classes
do not have the params.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
