bipinprasad commented on a change in pull request #3346:
URL: https://github.com/apache/storm/pull/3346#discussion_r524206002
##########
File path:
storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java
##########
@@ -410,6 +429,24 @@ protected SchedulingResult
scheduleExecutorsOnNodes(List<ExecutorDetails> ordere
int execIndex = searcherState.getExecIndex();
ExecutorDetails exec = searcherState.currentExec();
+
+ // If current exec is found in searcherState assigned Ackers,
+ // it means it has been assigned as a bound acker already.
+ // So we skip to the next.
+ if (searcherState.getBoundAckers().contains(exec)) {
+ if (searcherState.areAllExecsScheduled()) {
+ //Everything is scheduled correctly, so no need to search
any more.
+ LOG.info("scheduleExecutorsOnNodes: Done at loopCnt={} in
{}ms, state.elapsedtime={}, backtrackCnt={}, topo={}",
+ loopCnt, Time.currentTimeMillis() - startTimeMilli,
Review comment:
Should be System instead of Time on this line. Time on next line is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
