[GitHub] [storm] Ethanlm commented on a change in pull request #3368: [STORM-3729] fix assgin memory error over 2g

[GitBox]

Ethanlm commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548025714



##########
File path: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java
##########
@@ -94,13 +94,15 @@ public void parseJvmHeapMemByChildOptsTestM() {
         doParseJvmHeapMemByChildOptsTest("Xmx100M results in 100 MB", 
"Xmx100m", 100.0);
         doParseJvmHeapMemByChildOptsTest("Xmx100m results in 100 MB", 
"Xmx100M", 100.0);
         doParseJvmHeapMemByChildOptsTest("-Xmx100M results in 100 MB", 
"-Xmx100m", 100.0);
+       doParseJvmHeapMemByChildOptsTest("-Xmx2048M results in 2048 MB", 
"-Xmx2048m", 2048.0);

Review comment:
       nit: indention is a little off

##########
File path: storm-client/test/jvm/org/apache/storm/utils/UtilsTest.java
##########
@@ -94,13 +94,15 @@ public void parseJvmHeapMemByChildOptsTestM() {
         doParseJvmHeapMemByChildOptsTest("Xmx100M results in 100 MB", 
"Xmx100m", 100.0);
         doParseJvmHeapMemByChildOptsTest("Xmx100m results in 100 MB", 
"Xmx100M", 100.0);
         doParseJvmHeapMemByChildOptsTest("-Xmx100M results in 100 MB", 
"-Xmx100m", 100.0);
+       doParseJvmHeapMemByChildOptsTest("-Xmx2048M results in 2048 MB", 
"-Xmx2048m", 2048.0);
     }
 
     @Test
     public void parseJvmHeapMemByChildOptsTestG() {
         doParseJvmHeapMemByChildOptsTest("Xmx1g results in 1024 MB", "Xmx1g", 
1024.0);
         doParseJvmHeapMemByChildOptsTest("Xmx1G results in 1024 MB", "Xmx1G", 
1024.0);
         doParseJvmHeapMemByChildOptsTest("-Xmx1g results in 1024 MB", 
"-Xmx1g", 1024.0);
+       doParseJvmHeapMemByChildOptsTest("-Xmx2g results in 2048 MB", "-Xmx2g", 
2048.0);

Review comment:
       nit: indention is a little off




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org