bipinprasad commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548168376
##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1039,7 +1039,7 @@ public static Double
parseJvmHeapMemByChildOpts(List<String> options, Double def
}
Matcher m = optsPattern.matcher(option);
while (m.find()) {
- int value = Integer.parseInt(m.group(1));
+ long value = Long.parseLong(m.group(1));
Review comment:
Tested this - RHS is not getting promoted to a double. But the following
works with "int value:"
double result = 1.0 * value * unit / 1024.0 / 1024.0;
(without "1.0 *" the new case test fails)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
