Ethanlm commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548161633
##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1039,7 +1039,7 @@ public static Double
parseJvmHeapMemByChildOpts(List<String> options, Double def
}
Matcher m = optsPattern.matcher(option);
while (m.find()) {
- int value = Integer.parseInt(m.group(1));
+ long value = Long.parseLong(m.group(1));
Review comment:
`value * unit` has integer overflow so it equals to `-2147483648`.
Then `-2147483648 / 1024.0 / 1024.0 = -2048.0`, this is when it is casted to
double.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
