bipinprasad commented on a change in pull request #3368:
URL: https://github.com/apache/storm/pull/3368#discussion_r548178806
##########
File path: storm-client/src/jvm/org/apache/storm/utils/Utils.java
##########
@@ -1039,7 +1039,7 @@ public static Double
parseJvmHeapMemByChildOpts(List<String> options, Double def
}
Matcher m = optsPattern.matcher(option);
while (m.find()) {
- int value = Integer.parseInt(m.group(1));
+ long value = Long.parseLong(m.group(1));
Review comment:
@ethanlm that is definitely what is happening - but I find this
surprising, the expression should be widened to a double (set at compile time
because of doubles in the expression (1024.0).Maybe there is a fine print at
https://docs.oracle.com/javase/specs/jls/se8/html/jls-5.html.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
