Github user revans2 commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r10303899
--- Diff: storm-core/src/jvm/backtype/storm/task/TopologyContext.java ---
@@ -250,6 +252,22 @@ public void addTaskHook(ITaskHook hook) {
return metric;
}
+
+ /*
+ * Convinience method for ShellBolt to registering ShellMetric.
+ */
+ public <T extends IShellMetric> T registerMetric(String name, T
metric, int timeBucketSizeInSecs, ShellBolt bolt) {
--- End diff --
Oh I see how you are doing the single call. I think this is OK, I think my
suggestion is a bit more flexible so others could use it too, but if you want
to keep it this way I am fine with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
