Github user dashengju commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r10335279
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -120,12 +170,23 @@ private void querySubprocess(Object query) {
} else {
_collector.emitDirect((int)task.longValue(),
stream, tuple, messageId);
}
+ } else if (command.equals("metrics")) {
+ handleMetrics(action);
}
}
} catch (IOException e) {
throw new RuntimeException(e);
}
}
+
+ public <T extends IShellMetric> T registerMetric(String name, T
metric) {
--- End diff --
yes, I think your suggestion is more flexible and make the register
interface same with others.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
