Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/38#issuecomment-36897445
The code looks fine to me once you remove the unneeded imports. But I
would like to see a test updated to at least exercise some of these data paths,
but preferably some unit tests too. I should have mentioned it before, sorry.
You are doing great with the changes keep up the good work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
