Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r14294111
--- Diff: storm-core/test/clj/backtype/storm/metrics_test.clj ---
@@ -66,15 +70,17 @@
(def metrics-data backtype.storm.metric.testing/buffer)
-(defn wait-for-atleast-N-buckets! [N comp-id metric-name]
- (while
+(defn wait-for-atleast-N-buckets! [N comp-id metric-name cluster]
+ (while-timeout TEST-TIMEOUT-MS
(let [taskid->buckets (-> @metrics-data (get comp-id) (get
metric-name))]
(or
(and (not= N 0) (nil? taskid->buckets))
(not-every? #(<= N %) (map (comp count second) taskid->buckets))))
-;; (println "Waiting for at least" N "timebuckets to appear in
FakeMetricsConsumer for component id" comp-id
-;; "and metric name" metric-name)
- (Thread/sleep 10)))
+ ;;(log-message "Waiting for at least " N " timebuckets to appear in
FakeMetricsConsumer for component id " comp-id " and metric name " metric-name
" metrics " (-> @metrics-data (get comp-id) (get metric-name)))
--- End diff --
Could we just remove this commented line? Minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
