Github user d2r commented on a diff in the pull request:
https://github.com/apache/incubator-storm/pull/38#discussion_r14294104
--- Diff: storm-core/src/jvm/backtype/storm/multilang/JsonSerializer.java
---
@@ -135,6 +135,16 @@ public ShellMsg readShellMsg() throws IOException,
NoOutputException {
shellMsg.addAnchor((String) o);
}
}
+
+ Object nameObj = msg.get("name");
+ String metricName = null;
+ if (nameObj != null && nameObj instanceof String) {
+ metricName = (String) nameObj;
+ }
+ shellMsg.setMetricName(metricName);
--- End diff --
This will not throw a ClassCastException here like with several other keys
above (i.e., `"command"`). We would only see a NullPointerException in
ShellSpout or ShellBolt when we check that the String is not empty.
This is really minor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
