Hi Tim,
I was surprised to hear you mention that you and others in the community
dislike my PR, as I have not received any feedback from others. In
addition, to avoid missing your Email and causing mistakes, I checked my
email box. I do not think I have received any valuable feedback or
suggestions from you since you published the OSPP task as a mentor (as
shown in the attachment email file), except the comments in the PR today.
Consequently, I'm astonished that I do not meet the requirements.
I still have a few questions that I want to clarify:
The most important thing is: which part of the challenge do you believe I
do not complete? My current implementation is based on the task description
in OSPP and the proposal I submitted(which is reviewed and accepted by
you). The entire technical implementation process has fully implemented all
the details and has achieved the function of having pre-set assets when
opening StreamPipes.
>From your reply, I did not see any challenge which is impossible
to achieve. Here are all points I extracted from your email reply and PR
reply that need to be improved:
1. Enrich the assets in the PR. Your description of the asset is
confusing. Could you please give a rough description and an example?
2. In the documentation, clearly describe which components are in the
default assets and provide a detailed description of each component.
3. Adjust the method to wait for backend service.
Could you please explicitly tell me whether fixing these three points will
allow me to complete the challenge? If so, I can finish it quickly. If
not, please
tell me the reason.
Best wishes!
Qian Yang
2023.10.13
Q Yang <[email protected]> 于2023年10月13日周五 16:05写道：
>
>
> Tim Bossenmaier <[email protected]>于2023年10月13日 周五15:25写道：
>
>> Hi Qian Yang,
>>
>> I've just added some comments to your PR in the StreamPipes repository.
>>
>> Additionally, I just want to make it clear that (as mentioned in earlier
>> emails) the two existing PRs in their current state are not sufficient to
>> pass the OSPP challenge. This is not only my personal opinion, but also the
>> opinion of other Apache StreamPipes PMC members.
>> To emphasise this even more than in the PR comments, we simply feel that
>> the assets provided in the PR are not suitable for our goal of creating a
>> fascinating experience for first-time users of Apache StreamPipes.
>> Furthermore, the documentation you provide in the streampipes-website
>> repository does not guide the user. Sure, it clearly describes how to use
>> Quickstart mode from a technical perspective, but otherwise I think first
>> time users are lost once they open StreamPipes. Ideally, this part of the
>> documentation would not only show the user how to start the Quickstart
>> mode, but also guide them through their first steps in StreamPipes and
>> explain the resources available.
>>
>> I hope I have made my points clear and left no questions unanswered. If
>> so, feel free to contact me again.
>> In general, your contribution is good on a technical level, but it's just
>> not enough to meet the requirements of the challenge.
>>
>> Best regards
>> Tim
>>
>> -------- Originalnachricht --------
>> Betreff: Request for PR review
>> Datum: 10.10.2023 11:23
>> Von: Q Yang <[email protected]>
>> An: Tim Bossenmaier <[email protected]>
>>
>> Hi,Tim!
>> I notice that you have approved luoluoyuyu's PR, could you please review
>> my PR and give me some suggestions? If my PR has some problems, I'd like
>> to change it as soon as possible. Before the end of the month, I still
>> could change the PR. Could you give me a chance so that I could do it
>> better?
>>
>> Best wishes!
>> Qian Yang
>> 10.10
>>
>
--- Begin Message ---
Hi Qian Yang,
I just noticed that you have created a PR in the Apache StreamPipes
repository.
Unfortunately, I'm writing this while I'm on my way to vacation, so I won't
have a chance to review your PR.
Hopefully someone in the StreamPipes community can give you some feedback.
Best
Tim
Am Do., 21. Sept. 2023 um 16:44 Uhr schrieb Tim Bossenmaier <
[email protected]>:
> Hi Qian Yang,
>
> generally speaking, one way to get the JWT token into to context of your
> docker-compose is to use an environment variable.
>
> But again, even if we get your PR merged before the end of September, we
> (as the Apache StreamPipes team) do not rate this contribution as meeting
> our requirements. It is just a first step towards the expected outcome of
> this challenge. I'm sorry to say.
>
> Best
> Tim
>
> ---------------------------------------------------
> Betreff: Re: Inquiries about obtaining the jwt token(Please ignore the
> former email)
> Datum: 19.09.2023 10:40
> Von: Q Yang <[email protected]>
> An: Tim Bossenmaier <[email protected]>
>
> Hi, Tim!
> Thank you very much for your reminder of the remaining time, my current
> solution is in the early part because I cannot securely get the jwt
> token at present. In the past time, I have been stuck in this part for a
> really long time before this problem can be solved. I believe after
> solving this problem, I could package the script into dockerfile, and
> the file update, also the completion of the front end will be done with
> high efficiency. So I really want to get your help and accomplish the
> quick start mode before the deadline.
>
> The most big problem is: How to get the jwt token in the bash file? It
> seems the jwt token only generate after the user is log in, and it is
> saved from the front end to the local. So it really confuse me.
>
> I have another implementation idea, and I want to get your advice before
> I try it right away. If the way we currently upload assets requires
> authentication during the deployment phase, maybe we can add a flag that
> we don't have to verify if it's the first time we upload assets? After
> initializing the asset for the first time, if the user needs to upload
> the asset, the jwt token is required for authentication. I wonder if
> this approach will be acceptable.
>
> Ps. I don’t know what time will you have free time for Streampipes, I
> will appreciate it if you could let me know what time I could contact
> you in your time zone.
>
> Best
> Qian Yang
>
> Tim Bossenmaier <[email protected]>于2023年9月19日
> 周二16:01写道：
>
> > Hi,
> >
> > Thank you for explaining your ideas clearly.
> > I have also looked at your PR in the StreamPipes repository, which
> > seems at a very early stage. Do you have any further contributions
> > which you want to make available?
> >
> > Before we discuss potential solutions in depth, please note that the
> > deadline for code submissions for OSPP is 30th September, leaving only
> > 10 days. The remaining days are intended to get the PRs of
> > participants merged.
> > If you do not have a significant contribution ready right now and by
> > looking at the timeline from your proposal, I unfortunately do not
> > believe that the requirements for this challenge can be accomplished
> > within that time.
> >
> > In case your PR does not include the work you've done so far, please
> > feel free to update your current state (e.g., documentation/website
> > updates, quickstart mode, preset assets, frontend update) and I'll be
> > happy to have a look.
> >
> > Best
> > Tim
> >
> > ---------------------------------------
> > Betreff: Inquiries about obtaining the jwt token(Please ignore the
> > former email)
> > Datum: 18.09.2023 10:13
> > Von: Q Yang <[email protected]>
> > An: Tim Bossenmaier <[email protected]>
> >
> > Hi, Tim!
> >
> > When I tried to use docker to upload the default assets, the current
> > plan is to PUT THE TWO REQUESTS( PREVIEW AND IMPORT) TO UPLOAD THE
> > ASSETS INTO A BASH FILE so that the assets in the zip package can be
> > uploaded to the website by executing the init.sh file (which I use the
> > PR to explain the plan, I deleted this pr by mistake while syncing the
> > latest remote repository, so I'm not sure if you saw it ).
> >
> > The bash file is like this:
> >
> > TOKEN="<token>"
> >
> > ZIP_FILE="5e7648a1-f477-43c0-b47f-960e4efc21cf.zip"
> >
> > # POST preview request with curl
> > JSON_RESPONSE=$(curl --compressed -s -X POST
> > "http://localhost/streampipes-backend/api/v2/import/preview [1] [1]"
> > -H "Authorization: $TOKEN"
> > -F "file_upload=@$ZIP_FILE")
> >
> > echo "$JSON_RESPONSE"
> > JSON_PAYLOAD=$JSON_RESPONSE
> >
> > # POST upload request using curl
> > curl -i -X POST "http://localhost/streampipes-backend/api/v2/import
> > [2] [2]"
> >
> > -H "Authorization: $TOKEN"
> > -F "file_upload=@$ZIP_FILE"
> > -F "configuration=@-;type=application/json" <<< "$JSON_PAYLOAD"
> >
> > However, when sending a request, we need to obtain the jwt token,
> > which
> > make it difficult to realize it in the docker. During my test, I got
> > this token from the web page after logging in. So I wonder if there is
> > a
> > way to securely acquire jwt tokens during the deployment phase? I
> > think
> > if the jwt token could be obtained, the rest thing is to determine
> > what
> > assets should we consider as default asset.
> >
> > I THINK THIS MAY BE ANOTHER POTENTIAL SOLUTION: When I do log in
> > action,
> > I notice that the front end sends a lot of requests with jwt tokens.
> > Can
> > we implement the request to upload assets through Angular, Just like
> > the
> > getAllResources defined in base-asset-links.direction.ts?
> >
> > First, we could get the zip list of default assets to upload with
> > getAllDefaultAssets.
> >
> > Second,loop through the actions of the two buttons, performPreview and
> > performImport().
> >
> > I wonder if this is a possible way to realize the quick start mode?
> >
> > Do you have any suggestions on how to get this token in the previous
> > scheme? Or do you have any ideas for the new plan? I'm sorry that I
> > delayed a lot of time because of the review of the course exam before.
> > Now I am trying to complete a perfect plan efficiently. If possible,
> > maybe we could use Zoom or Teams to discuss the plan by voice?
> >
> > Links:
> > ------
> > [1] http://localhost/streampipes-backend/api/v2/import/preview [1]
> > [2] http://localhost/streampipes-backend/api/v2/import [2]
>
>
> Links:
> ------
> [1] http://localhost/streampipes-backend/api/v2/import/preview
> [2] http://localhost/streampipes-backend/api/v2/import
>
--- End Message ---
--- Begin Message ---
Hi, Tim!
I am so excited to hear from you! Thank you for selecting my application,
it is my honor to contribute to Streampipes😊😉 I will upload the proposal
to the discussion in the community as soon as possible!
Best
Qian Yang
Tim Bossenmaier <[email protected]> 于2023年7月2日周日 23:57写道：
> Hello Qian Yang,
>
> first of all, congratulations, your proposal for our OSPP competition has
> been accepted by the committee!
> This means that we can start working on it directly.
> From my point of view, the first step would be for you to present your
> proposal and ideas to the StreamPipes developer community. I think the best
> way to do this is to open a discussion on GitHub. That way we can all
> discuss your proposal together and help you get started.
>
> I am very excited to hear your contributions and look forward to working
> with you,
>
> Best
> Tim
>
> PS: Sorry for getting back to you so late, I was on vacation until today :)
>
--- End Message ---
