Hi Qian, since this is a discussion about OSPP performance and therefore somehow personal, I'd prefer to discuss the topic in private and not on the dev list (which is public to anyone).
We will discuss the matter and your questions in the PMC and come back to you. If you want to include the PMC in your future mails, you can cc or send an email to [email protected] at any time (the list is moderated, but your message will get through). Thanks for your understanding and have a nice weekend! Cheers, Dominik On 2023/10/13 09:38:06 Q Yang wrote: > Hi Tim, > > I was surprised to hear you mention that you and others in the community > dislike my PR, as I have not received any feedback from others. In > addition, to avoid missing your Email and causing mistakes, I checked my > email box. I do not think I have received any valuable feedback or > suggestions from you since you published the OSPP task as a mentor (as > shown in the attachment email file), except the comments in the PR today. > Consequently, I'm astonished that I do not meet the requirements. > > > I still have a few questions that I want to clarify: > > > The most important thing is: which part of the challenge do you believe I > do not complete? My current implementation is based on the task description > in OSPP and the proposal I submitted(which is reviewed and accepted by > you). The entire technical implementation process has fully implemented all > the details and has achieved the function of having pre-set assets when > opening StreamPipes. > > From your reply, I did not see any challenge which is impossible > to achieve. Here are all points I extracted from your email reply and PR > reply that need to be improved: > > 1. Enrich the assets in the PR. Your description of the asset is > confusing. Could you please give a rough description and an example? > 2. In the documentation, clearly describe which components are in the > default assets and provide a detailed description of each component. > 3. Adjust the method to wait for backend service. > > Could you please explicitly tell me whether fixing these three points will > allow me to complete the challenge? If so, I can finish it quickly. If > not, please > tell me the reason. > > > Best wishes! > Qian Yang > 2023.10.13 > > > Q Yang <[email protected]> 于2023年10月13日周五 16:05写道： > > > > > > > Tim Bossenmaier <[email protected]>于2023年10月13日 周五15:25写道： > > > >> Hi Qian Yang, > >> > >> I've just added some comments to your PR in the StreamPipes repository. > >> > >> Additionally, I just want to make it clear that (as mentioned in earlier > >> emails) the two existing PRs in their current state are not sufficient to > >> pass the OSPP challenge. This is not only my personal opinion, but also the > >> opinion of other Apache StreamPipes PMC members. > >> To emphasise this even more than in the PR comments, we simply feel that > >> the assets provided in the PR are not suitable for our goal of creating a > >> fascinating experience for first-time users of Apache StreamPipes. > >> Furthermore, the documentation you provide in the streampipes-website > >> repository does not guide the user. Sure, it clearly describes how to use > >> Quickstart mode from a technical perspective, but otherwise I think first > >> time users are lost once they open StreamPipes. Ideally, this part of the > >> documentation would not only show the user how to start the Quickstart > >> mode, but also guide them through their first steps in StreamPipes and > >> explain the resources available. > >> > >> I hope I have made my points clear and left no questions unanswered. If > >> so, feel free to contact me again. > >> In general, your contribution is good on a technical level, but it's just > >> not enough to meet the requirements of the challenge. > >> > >> Best regards > >> Tim > >> > >> -------- Originalnachricht -------- > >> Betreff: Request for PR review > >> Datum: 10.10.2023 11:23 > >> Von: Q Yang <[email protected]> > >> An: Tim Bossenmaier <[email protected]> > >> > >> Hi,Tim! > >> I notice that you have approved luoluoyuyu's PR, could you please review > >> my PR and give me some suggestions? If my PR has some problems, I'd like > >> to change it as soon as possible. Before the end of the month, I still > >> could change the PR. Could you give me a chance so that I could do it > >> better? > >> > >> Best wishes! > >> Qian Yang > >> 10.10 > >> > > >
