If its any help, the correct commons validator jar contains the the validator_1_1_3.dtd
Niall ----- Original Message ----- From: "Martin Cooper" <[EMAIL PROTECTED]> To: "Niall Pemberton" <[EMAIL PROTECTED]> Cc: "Struts Developers List" <[EMAIL PROTECTED]> Sent: Wednesday, September 01, 2004 8:22 AM Subject: Re: Struts 1.2.2 Dead in the Water? > On Wed, 1 Sep 2004 08:11:06 +0100, Niall Pemberton > <[EMAIL PROTECTED]> wrote: > > Martin, > > > > I tested out the Struts 1.2.3 binary distribution you uploaded. The JDK > > issue is resolved but the wrong version of the validator jar is still being > > shipped. Now though its more consistent because the "lib" distribution also > > has the wrong jar as well :-) > > Fooey. Odd. My local path says it's 1.1.3. Not sure what's wrong. I'll > check this later today. > > > The disappointing thing from my point of view was that I put a checklist for > > testing various JDK/Tomcat flavours in the Struts 1.2.2 release plan - but > > it was removed. If they had been left in the plan then the JDK issues would > > have been caught. > > IMHO, you should put the checklist back. I know it seems, to some > folks, like a lot of overhead, but I learned my lesson, as an RM, a > few releases ago. Testing the release properly is *by far* the most > time-consuming part of being an RM, and it's probably the most > important as well. > > > I've set up a new plan for Struts 1.2.3 on the wiki: > > > > http://wiki.apache.org/struts/StrutsRelease123 > > Saw that. I just volunteered as RM... ;-) > > -- > Martin Cooper > > > > > > Niall > > > > > > > > ----- Original Message ----- > > From: "Martin Cooper" <[EMAIL PROTECTED]> > > To: "Struts Developers List" <[EMAIL PROTECTED]> > > Sent: Wednesday, September 01, 2004 6:28 AM > > Subject: Re: Struts 1.2.2 Dead in the Water? > > > > > On Wed, 1 Sep 2004 05:16:44 +0100, Niall Pemberton > > > <[EMAIL PROTECTED]> wrote: > > > > I've just got round to testing Struts 1.2.2 and found the following > > major > > > > problems: > > > > > > > > * The binary distribution contains the wrong version of commons > > validator > > > > jar (the lib distribution seems to have the right one). > > > > > > This leads me to believe that the binary and lib distros come from > > > different builds, which seems pretty odd. The 'release' target builds > > > everything at once. > > > > > > > * Struts 1.2.2 is incompatible with JDK 1.3 because it uses > > > > Boolean.valueOf(boolean) introduced in JDK 1.4 > > > > > > This was my fault for doing what FindBugs told me. ;-{ Pity nobody > > > caught it before 1.2.2 went out. > > > > > > > Also this distribution has been built/packaged differently to previous > > > > releases and IMO we should be doing things consistently: > > > > > > > > * The binary distribution zip file explodes to > > jakarta-struts-1.2.2/dist/ > > > > directory rather than just jakarta-struts-1.2.2/ > > > > * The source distribution zip file explodes to jakarta-struts directory > > > > rather than jakarta-struts-1.2.2-src > > > > * The source distribution contains all the CVS directories and files > > > > > > This is very strange. I just ran 'ant release' on my local system, and > > > it worked just fine, creating all of the uploads correctly. I see none > > > of the above issues. Perhaps James built the distros some other way? > > > Not sure. > > > > > > > James has just fixed the JDK 1.3 incompatibilities in CVS but I would > > say we > > > > need to downgrade the 1.2.2 version from a GA quality release and cut a > > new > > > > one. > > > > > > Yes indeed. I've updated the build version, rolled a new release > > > distribution, and am in the process of uploading it to cvs.apache.org. > > > I have not tested it yet, and have not signed it, but if people have > > > the chance to try it out, that would be very helpful. > > > > > > -- > > > Martin Cooper > > > > > > > > > > > > > > Niall > > > > > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
